-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO-1531: Migrate static hosting to CDK v2 #1062
DO-1531: Migrate static hosting to CDK v2 #1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge change so docs need to be updated. Can you update the README please? 🙏
I've probably missed a bit because this is a lot to process 😅 Updating docs will help heaps!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just an upgrade but while we are here can we add class properties of the underlying resources (e.g. s3 buckets, distribiton, etc). That way if we need to modify them outside the construct we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but probably best to get another DO to review too 🙏
* add viewer protocol policy to redirect http to https
* fix incorrect handler name
Description of the proposed changes
static-hosting
Only relevant changeset are these two files for now
Changes to other packages can be iteratively migrated upon. I didn't want to open one giant PR with changes in every package.