Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1531: Migrate static hosting to CDK v2 #1062

Merged
merged 13 commits into from
Sep 27, 2023

Conversation

gowrizrh
Copy link
Contributor

@gowrizrh gowrizrh commented Jul 31, 2023

Description of the proposed changes

  • Delete packages and migrate static-hosting

Only relevant changeset are these two files for now
image

Changes to other packages can be iteratively migrated upon. I didn't want to open one giant PR with changes in every package.

@gowrizrh gowrizrh marked this pull request as ready for review July 31, 2023 06:23
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge change so docs need to be updated. Can you update the README please? 🙏

I've probably missed a bit because this is a lot to process 😅 Updating docs will help heaps!

packages/static-hosting/lib/static-hosting.ts Outdated Show resolved Hide resolved
packages/static-hosting/lib/static-hosting.ts Show resolved Hide resolved
packages/static-hosting/lib/static-hosting.ts Show resolved Hide resolved
packages/static-hosting/lib/static-hosting.ts Show resolved Hide resolved
packages/static-hosting/lib/static-hosting.ts Show resolved Hide resolved
packages/static-hosting/lib/static-hosting.ts Show resolved Hide resolved
Copy link
Contributor

@AdamJHall AdamJHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just an upgrade but while we are here can we add class properties of the underlying resources (e.g. s3 buckets, distribiton, etc). That way if we need to modify them outside the construct we can.

packages/static-hosting/lib/static-hosting.ts Show resolved Hide resolved
@gowrizrh gowrizrh changed the title DO-1446: Migrate static hosting to CDK v2 DO-1531: Migrate static hosting to CDK v2 Sep 26, 2023
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but probably best to get another DO to review too 🙏

* add viewer protocol policy to redirect http to
https
* fix incorrect handler name
@gowrizrh gowrizrh merged commit c010dde into epic/cdk-v2 Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants