Merge pull request #1408 from aligent/feature/Optionally-Disable-Exec

FEAT: Add prop to disable ECS exec
aligent · Nov 22, 2024 · 7ff2635 · 7ff2635
2 parents 1d292fd + 5d7154e
commit 7ff2635
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/graphql-mesh-server/lib/fargate.ts b/packages/graphql-mesh-server/lib/fargate.ts
@@ -232,6 +232,12 @@ export interface MeshServiceProps {
    * }
    */
   cpuStepScalingOptions?: Partial<BasicStepScalingPolicyProps>;
+
+  /**
+   * Enable ECS Exec on the fargate containers
+   * @default true
+   */
+  enableEcsExec?: boolean;
 }
 
 export class MeshService extends Construct {
@@ -412,7 +418,7 @@ export class MeshService extends Construct {
         serviceName:
           props.serviceName !== undefined ? props.serviceName : undefined,
         certificate,
-        enableExecuteCommand: true,
+        enableExecuteCommand: props.enableEcsExec ?? true,
         cpu: props.cpu || 512, // 0.5 vCPU
         memoryLimitMiB: props.memory || 1024, // 1 GB
         taskDefinition: taskDefinition,

diff --git a/packages/graphql-mesh-server/lib/graphql-mesh-server.ts b/packages/graphql-mesh-server/lib/graphql-mesh-server.ts
@@ -226,6 +226,12 @@ export type MeshHostingProps = {
    * @default - AWS Generated name
    */
   dashboardName?: string;
+
+  /**
+   * Enable ECS Exec on the fargate containers
+   * @default true
+   */
+  enableEcsExec?: boolean;
 };
 
 export class MeshHosting extends Construct {