Skip to content

Commit

Permalink
DO-1530: remove skip lib check
Browse files Browse the repository at this point in the history
and include DOM lib
  • Loading branch information
gowrizrh committed Oct 5, 2023
1 parent 880525b commit 366226a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
5 changes: 4 additions & 1 deletion packages/esbuild/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "../../tsconfig.json"
"extends": "../../tsconfig.json",
"compilerOptions": {
"skipLibCheck": true
}
}
7 changes: 1 addition & 6 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"target": "ES2018",
"module": "commonjs",
"lib": ["es2018"],
"lib": ["es2018", "DOM"],
"declaration": true,
"strict": true,
"noImplicitAny": true,
Expand All @@ -19,11 +19,6 @@
"strictPropertyInitialization": false,
"typeRoots": ["./node_modules/@types"],
"types": ["node", "jest"],

// https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/826
// Ideally this should only be specified in packages/esbuild/tsconfig.json, however it doesn't seem to be
// loading that config file during build.
"skipLibCheck": true
},
"exclude": ["**/node_modules", "cdk.out", "**/handlers/**"]
}

0 comments on commit 366226a

Please sign in to comment.