Merge pull request #131 from aligent/release/1.8.1

Release/1.8.1
aligent · May 19, 2022 · b2c1627 · b2c1627
2 parents d6e1e7e + 9439793
commit b2c1627
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,7 +1,7 @@
-### New Features
+### Fixes
+
+- Fixes _Undefined index within customer getByEmail method_ (thanks @dniccum)
 
-- Implement V2 Order Products API
-- Implement V2 Order Shipping Addresses API (read-only)
 
 
 

diff --git a/src/BigCommerce/Api/Customers/CustomersApi.php b/src/BigCommerce/Api/Customers/CustomersApi.php
@@ -33,7 +33,7 @@ public function getByEmail(string $email): ?Customer
     {
         $customers = $this->getAll([self::FILTER__EMAIL_IN => $email])->getCustomers();
 
-        if (!$customers[0]) {
+        if (count($customers) === 0) {
             return null;
         } elseif (count($customers) > 1) {
             throw new UnexpectedValueException("There are more than one customer with the email address $email");

diff --git a/tests/BigCommerce/Api/Customers/CustomersApiTest.php b/tests/BigCommerce/Api/Customers/CustomersApiTest.php
@@ -38,6 +38,14 @@ public function testCanGetCustomerByEmail()
         $this->assertEquals('John', $customer->first_name);
     }
 
+    public function testUnknownCustomerReturnsEmptyResult()
+    {
+        $this->setReturnData('customers__get_all_no_results.json');
+        $customer = $this->getApi()->customers()->getByEmail('[email protected]');
+
+        $this->assertNull($customer);
+    }
+
     public function testCanGetCustomerById()
     {
         $this->setReturnData('customers__get_all.json');