Image processing regex management update #1774
Open
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
requested review from
fabiencastan,
cbentejac and
servantftechnicolor
cbentejac
force-pushed
the
bugfix/imageProcessing_regex
branch
from
d4e83e7
to
da0187f
Compare
demoulinv
force-pushed
the
bugfix/imageProcessing_regex
branch
from
da0187f
to
d72891d
Compare
cbentejac
force-pushed
the
bugfix/imageProcessing_regex
branch
from
d201029
to
f051430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR update the behavior of the imageProcessing executable when both input folder(s) and a regular input expression exist in the command line.
In the current version, input folders given in the command line are ignored if a regular expression is also given.
This PR applies the regular expression in all the input folders.
Nothing is changed if a the input is a sfmData file.
Additionally, if the output directory does not exist, it is created. If for some reason it cannot be created, an error is returned.
imageProcessing version is updated to 3.4
Features list
Implementation remarks