Depth/normal maps rendering from Mesh #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftechnicolor
force-pushed
the
dev/generateDepth
branch
2 times, most recently
from
1e2dfc1
to
44613ef
Compare
fabiencastan
reviewed
Oct 3, 2024
Comment on lines
+73
to
+74
| ray.direction.y = -dir.y(); | ||
| ray.direction.z = -dir.z(); |
There was a problem hiding this comment.
Should we convert it here or convert on the load of the OBJ as we usually do (to keep the CV coordinates everywhere)?
There was a problem hiding this comment.
This looks much more efficient given that, for lidar files, the number of vertices is way higher than the number of peeks in an image.
servantftechnicolor
force-pushed
the
dev/generateDepth
branch
from
44613ef
to
d3f7f4c
Compare
fabiencastan
approved these changes
Oct 17, 2024
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate synthetic (depth/normal)maps using pose and intrinsics from sfmData and a mesh.
If the sfmData contains n views with pose and intrinsics then this node will generate n (depth/normal)maps