Skip to content
This repository has been archived by the owner on Jun 4, 2018. It is now read-only.

Fix build script in OS X #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build script in OS X #1

wants to merge 2 commits into from

Conversation

nicolunacba
Copy link

In some platforms (like OS X) the sed command needs the parameter -i as -i.bak. Also, seems like OS X is strict about the order of the parameters in cp command.

@alice-mkh
Copy link
Owner

Hello. -I.bak option seems to create unneeded backups of the changed files, which creates duplicate files in the output xpi.

@nicolunacba
Copy link
Author

@Exalm You're right. In order to not create backup files, I changed the sed command specifying a zero-length extension.

https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man1/sed.1.html

@alice-mkh
Copy link
Owner

~/Development/mozilla/search-sidebar $ LANG="en_US.UTF-8" ./build
sed: can't read s|$EXT_ID|[email protected]|g: No such file or directory
sed: can't read s|$EXT_NAME|SearchSidebar|g: No such file or directory
sed: can't read s|$EXT_DESC|Full-featured Search sidebar for SeaMonkey|g: No such file or directory
sed: can't read s|$NAME|searchSidebar|g: No such file or directory
sed: can't read s|$VERSION|0.1|g: No such file or directory
sed: can't read s|$SM_ID|{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}|g: No such file or directory
sed: can't read s|$SM_MIN_VERSION|2.17|g: No such file or directory
sed: can't read s|$SM_MAX_VERSION|2.40|g: No such file or directory
~/Development/mozilla/search-sidebar $

@nicolunacba
Copy link
Author

@Exalm Just installed a Linux VM and my change doesn't work on it. The only thing I can do is:

  • keep -i.bak
  • remove .bak files before create the zip by find . -type f -name "*.bak" -exec rm -f {} \;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants