-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feishu plugin to SAA #149
base: main
Are you sure you want to change the base?
Conversation
you can run |
<parent> | ||
<groupId>org.springframework.boot</groupId> | ||
<artifactId>spring-boot-starter-parent</artifactId> | ||
<version>3.1.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be consistent with the boot version of spring ai alibaba
btw, you can see:
spring-ai-alibaba/community/plugins/spring-ai-alibaba-starter-plugin-baidusearch/pom.xml
Line 23 in 0cf7c70
<groupId>com.alibaba.cloud.ai</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,I will update this groupid
<java.version>17</java.version> | ||
</properties> | ||
|
||
<dependencyManagement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the transitive relationship of mvn, after introducing the above parent, there is no need to introduce it again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
</dependency> | ||
<dependency> | ||
<groupId>com.fasterxml.jackson.core</groupId> | ||
<artifactId>jackson-annotations</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need this dependency. maybe can delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
<artifactId>jsoup</artifactId> | ||
<version>1.18.1</version> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but I saw that this dependency was used in the other plugins in the project
@@ -0,0 +1,101 @@ | |||
package com.alibaba.cloud.ai.plugin.feishu; | |||
|
|||
import com.google.gson.JsonParser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you have used jackson. The global situation should be unified. There is no need for gson here. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@Bean | ||
@ConditionalOnMissingBean | ||
@Description("Build FeiShu Client in Spring AI Alibaba")// description | ||
@ConditionalOnProperty( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a plugin, I don’t think we need this configuration. cc @chickenlj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reader of Feishu,users need to configure their own appid and appSecret
* @author <a href="mailto:[email protected]">wudihaoke214</a> | ||
*/ | ||
@SpringBootTest | ||
class SpringAiAlibabaStarterPluginFeiShuApplicationTests { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no test class, you can delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
add feishu plugin to SAA