Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feishu plugin to SAA #149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wblu214
Copy link
Contributor

@wblu214 wblu214 commented Dec 1, 2024

add feishu plugin to SAA

@wblu214
Copy link
Contributor Author

wblu214 commented Dec 1, 2024

image
maven bulid error!!

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Dec 1, 2024

you can run mvn spring-javaformat:apply

<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.1.1</version>
Copy link
Contributor

@yuluo-yx yuluo-yx Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be consistent with the boot version of spring ai alibaba

btw, you can see:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,I will update this groupid

<java.version>17</java.version>
</properties>

<dependencyManagement>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the transitive relationship of mvn, after introducing the above parent, there is no need to introduce it again here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need this dependency. maybe can delete it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

<artifactId>jsoup</artifactId>
<version>1.18.1</version>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but I saw that this dependency was used in the other plugins in the project

@@ -0,0 +1,101 @@
package com.alibaba.cloud.ai.plugin.feishu;

import com.google.gson.JsonParser;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you have used jackson. The global situation should be unified. There is no need for gson here. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Bean
@ConditionalOnMissingBean
@Description("Build FeiShu Client in Spring AI Alibaba")// description
@ConditionalOnProperty(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a plugin, I don’t think we need this configuration. cc @chickenlj

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reader of Feishu,users need to configure their own appid and appSecret

* @author <a href="mailto:[email protected]">wudihaoke214</a>
*/
@SpringBootTest
class SpringAiAlibabaStarterPluginFeiShuApplicationTests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no test class, you can delete it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants