Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ext_default_encoder with prometheus encoder #1704

Merged
merged 9 commits into from
Aug 22, 2024
Merged

feat: add ext_default_encoder with prometheus encoder #1704

merged 9 commits into from
Aug 22, 2024

Conversation

aiops1900
Copy link
Contributor

  1. [FEATURE]: iLogtail的extension新增encoder接口 [ 详见 [FEATURE]: iLogtail的extension新增encoder接口 #1660 ]
  2. [FEATURE]: iLogtail 新增 Prometheus Protocol Encoder 实现 [ 详见 [FEATURE]: iLogtail 新增 Prometheus Protocol Encoder 实现 #1661 ]
  3. [FEATURE]: iLogtail的extension插件新增encoder extension插件[ext_default_encoder] [ 详见 [FEATURE]: iLogtail的extension插件新增encoder extension插件[ext_default_encoder] #1662 ]

以flusher_http的配置为例，集成Prometheus Encoder的配置示例

flushers:
- Type: flusher_http
  ...
  Encoder:
    Type: ext_default_encoder/prometheus
    ...
...
extensions:
- Type: ext_default_encoder/prometheus
  Format: 'prometheus'

yyuuttaaoo
yyuuttaaoo requested changes Aug 20, 2024
View reviewed changes
pkg/protocol/encoder/protocol.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件位置和endocoder不太对称，可以统一吗

plugins/extension/encoder/encoder.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和default_decoder.go统一一下？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

plugins/extension/encoder/encoder.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对应的文档，参考 https://github.com/alibaba/ilogtail/blob/2.0/docs/cn/plugins/extension/ext-default-decoder.md
加入overview docs/cn/plugins/overview.md
顺便把链接加一下（原来整个Extension都漏了）docs/cn/SUMMARY.md

@aiops1900 aiops1900 changed the title [FEATURE]: iLogtail的extension新增encoder接口，增加prometheus encoder实现，增加ext_default_encoder插件[通过配置使用prometheus encoder] feat: add ext_default_encoder with prometheus encoder which implements encoder extension interface Aug 20, 2024
@aiops1900 aiops1900 changed the title feat: add ext_default_encoder with prometheus encoder which implements encoder extension interface feat: add ext_default_encoder with prometheus encoder Aug 20, 2024
@yyuuttaaoo yyuuttaaoo added the enhancement Feature enhancement label Aug 22, 2024
@yyuuttaaoo yyuuttaaoo added this to the v2.2 milestone Aug 22, 2024
@yyuuttaaoo yyuuttaaoo merged commit e32c782 into alibaba:main Aug 22, 2024
15 checks passed
@yyuuttaaoo yyuuttaaoo modified the milestones: v2.2, v2.1 Aug 22, 2024
@yyuuttaaoo yyuuttaaoo mentioned this pull request Sep 10, 2024
Closed
This was linked to issues Sep 10, 2024
[FEATURE]: iLogtail的extension插件新增encoder extension插件[ext_default_encoder] #1662
Open
[ENHANCEMENT]: iLogtail的flusher_http支持extension Encoder且适配相应的逻辑 #1665
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

Assignees
No one assigned
Labels
enhancement Feature enhancement
Projects
None yet
Milestone
v2.1
2 participants
@aiops1900 @yyuuttaaoo