Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not mutate data return by useSuspenseData when csr #6434

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Jul 31, 2023

Do not mutate data return by useSuspenseData when csr, otherwise it may cause mulit time render in nested withSuspense.

@ClarkXia ClarkXia added the need review Need Review label Jul 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage: 13.55% and project coverage change: -0.10% ⚠️

Comparison is base (e40a7cb) 80.36% compared to head (bd27696) 80.26%.
Report is 1 commits behind head on release/next.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/next    #6434      +/-   ##
================================================
- Coverage         80.36%   80.26%   -0.10%     
================================================
  Files               237      237              
  Lines             21454    21490      +36     
  Branches           2650     2650              
================================================
+ Hits              17242    17250       +8     
- Misses             4168     4196      +28     
  Partials             44       44              
Files Changed Coverage Δ
packages/runtime/src/Suspense.tsx 28.39% <13.55%> (-1.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia changed the base branch from release/next to master August 1, 2023 03:29
@ClarkXia ClarkXia changed the base branch from master to release/next August 1, 2023 03:29
@ClarkXia ClarkXia changed the base branch from release/next to master August 1, 2023 06:04
@ClarkXia ClarkXia changed the base branch from master to release/next August 1, 2023 06:04
@ClarkXia ClarkXia merged commit 11dd752 into release/next Aug 2, 2023
6 checks passed
@ClarkXia ClarkXia deleted the fix/suspense-data branch August 2, 2023 04:22
@ClarkXia ClarkXia mentioned this pull request Aug 2, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants