fix: build warning of runApp is not exported (#6438)

* fix: build warning of runApp is not exported * chore: remove log * fix: render
alibaba · Aug 3, 2023 · 9978372 · 9978372
1 parent 67eae5c
commit 9978372
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/packages/ice/src/createService.ts b/packages/ice/src/createService.ts
@@ -69,11 +69,7 @@ async function createService({ rootDir, command, commandArgs }: CreateServiceOpt
     command,
   });
 
-  let entryCode = `if (app.runApp) {
-  app.runApp(render, renderOptions);
-} else {
-  render();
-}`;
+  let entryCode = 'render();';
 
   const generatorAPI = {
     addExport: (declarationData: Omit<DeclarationData, 'declarationType'>) => {

diff --git a/packages/ice/templates/core/entry.client.tsx.ejs b/packages/ice/templates/core/entry.client.tsx.ejs
@@ -49,7 +49,7 @@ const renderOptions: RunClientAppOptions = {
   },
 };
 
-const render = (customOptions: Record<string, any> = {}) => {
+const defaultRender = (customOptions: Partial<RunClientAppOptions> = {}) => {
   return runClientApp({
     ...renderOptions,
     ...customOptions,
@@ -60,6 +60,18 @@ const render = (customOptions: Record<string, any> = {}) => {
   });
 };
 
+const renderApp = (appExport: any, customOptions: Partial<RunClientAppOptions>) => {
+  if (appExport.runApp) {
+    return appExport.runApp(defaultRender, renderOptions);
+  } else {
+    return defaultRender(customOptions);
+  }
+};
+
+const render = (customOptions: Partial<RunClientAppOptions> = {}) => {
+  renderApp(app, customOptions);
+};
+
 <%- entryCode %>
 
 if (import.meta.webpackHot) {