fix: 🐛 [frontend-gray] 修复 请求非首页资源时候，路由配置 #1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heimanba
requested review from
johnlanni,
WeixinX and
CH3CHO
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
+ Coverage 35.91% 44.21% +8.30%
==========================================
Files 69 76 +7
Lines 11576 9895 -1681
==========================================
+ Hits 4157 4375 +218
+ Misses 7104 5184 -1920
- Partials 315 336 +21 |
CH3CHO
reviewed
Sep 28, 2024
| deployment = util.FilterGrayWeight(&grayConfig, preVersion, preUniqueClientId, uniqueClientId) | ||
| } else { | ||
| deployment = util.FilterGrayRule(&grayConfig, grayKeyValue) | ||
| } | ||
| log.Infof("index deployment: %v, path: %v, backend: %v, xPreHigressVersion: %s,%s", deployment, path, deployment.BackendVersion, preVersion, preUniqueClientId) | ||
| } else { | ||
| deployment = util.GetVersion(grayConfig, deployment, preVersion, isPageRequest) | ||
| grayDeployment := deployment | ||
| if deployment.Version == "" { |
There was a problem hiding this comment.
这个地方 deployment.Version 可能不是空吗？
There was a problem hiding this comment.
我捋一下这段的逻辑哦。
- 如果是页面请求：
- 如果配了权重，就按权重选择目标版本
- 如果没配权重，就按规则选择目标版本
- 这里不考虑当前请求中是否包含灰度 Cookie
- 如果不是页面请求：
- 不看权重，只按规则选择目标版本
- 如果 Cookie 中包含当前灰度版本信息，则优先选择 Cookie 中声明的版本
请问我理解的对吗？
There was a problem hiding this comment.
这个地方
deployment.Version可能不是空吗？
可能的 ，因为有可能不经过首页html。直接访问 .css这样的文件，灰度规则会失效
There was a problem hiding this comment.
我捋一下这段的逻辑哦。
如果是页面请求：
- 如果配了权重，就按权重选择目标版本
- 如果没配权重，就按规则选择目标版本
- 这里不考虑当前请求中是否包含灰度 Cookie
如果不是页面请求：
- 不看权重，只按规则选择目标版本
- 如果 Cookie 中包含当前灰度版本信息，则优先选择 Cookie 中声明的版本
请问我理解的对吗？
是的，有Cookie的话，就认为是 页面请求种下的Cookie，这样可以做请求黏贴。
There was a problem hiding this comment.
这个地方
deployment.Version可能不是空吗？可能的 ，因为有可能不经过首页html。直接访问 .css这样的文件，灰度规则会失效
但根据下图，deployment 对象创建之后，直接就会进行 version 是否为空的判定。这里应该不会不为空吧？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bugfix] 修复 请求非首页资源时候，路由配置