fix remove TODO exception for issue #3192

alibaba · Dec 5, 2024 · 99b8ef8 · 99b8ef8
1 parent 0293061
commit 99b8ef8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/core/src/main/java/com/alibaba/fastjson2/JSONPathSegment.java b/core/src/main/java/com/alibaba/fastjson2/JSONPathSegment.java
@@ -1285,10 +1285,7 @@ public void accept(JSONReader jsonReader, JSONPath.Context context) {
                     context.value = values;
                 }
                 context.eval = true;
-                return;
             }
-
-            throw new JSONException("TODO");
         }
     }
 

diff --git a/core/src/test/java/com/alibaba/fastjson2/issues_3100/Issue3192.java b/core/src/test/java/com/alibaba/fastjson2/issues_3100/Issue3192.java
@@ -0,0 +1,20 @@
+package com.alibaba.fastjson2.issues_3100;
+
+import com.alibaba.fastjson.JSON;
+import com.alibaba.fastjson2.JSONPath;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class Issue3192 {
+    @Test
+    public void test_jsonpath_array() {
+        String json = "{ \"array\": null }";
+        assertEquals("[]", JSON.toJSONString(JSONPath.extract(json, "$.array[0].key", JSONPath.Feature.KeepNullValue, JSONPath.Feature.AlwaysReturnList)));
+        assertEquals("[]", JSON.toJSONString(JSONPath.extract(json, "$.array[*].key", JSONPath.Feature.KeepNullValue, JSONPath.Feature.AlwaysReturnList)));
+
+        json = "{ \"array\": [{\"key\":1}, {\"key\":null}, {\"key\":3}] }";
+        assertEquals("[1]", JSON.toJSONString(JSONPath.extract(json, "$.array[0].key", JSONPath.Feature.KeepNullValue, JSONPath.Feature.AlwaysReturnList)));
+        assertEquals("[1,null,3]", JSON.toJSONString(JSONPath.extract(json, "$.array[*].key", JSONPath.Feature.KeepNullValue, JSONPath.Feature.AlwaysReturnList)));
+    }
+}
-Original file line number
+Diff line change
@@ Expand Up @@
                         context.value = values;
                     }
                     context.eval = true;
-                    return;
                 }
-                throw new JSONException("TODO");
             }
         }
@@ Expand Down @@