very basic work-stealing #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
force-pushed
the
work-stealing
branch
from
408655d
to
961a29e
Compare
lihuiba
force-pushed
the
work-stealing
branch
from
961a29e
to
586c167
Compare
Coldwings
reviewed
Dec 2, 2024
| stack_size = DEFAULT_STACK_SIZE; | ||
| if (unlikely((uint64_t)reserved_space > stack_size / 2)) | ||
| LOG_ERROR_RETURN(EINVAL, nullptr, VALUE(reserved_space), "must be <= half of ", VALUE(stack_size)); | ||
| uint64_t FLAGS = THREAD_JOINABLE | THREAD_ENABLE_WORK_STEALING; |
There was a problem hiding this comment.
FLAGS looks like just a simple const value, should be defined as const or constexpr.
| @@ -1884,7 +2018,11 @@ R"( | |||
| return _n_vcpu.load(std::memory_order_relaxed); | |||
| } | |||
|
|
|||
| int vcpu_init() { | |||
| int vcpu_init(uint64_t flags) { | |||
| uint64_t FLAGS = VCPU_ENABLE_ACTIVE_WORK_STEALING | | |||
| @@ -61,8 +65,10 @@ namespace photon | |||
| const uint64_t DEFAULT_STACK_SIZE = 8 * 1024 * 1024; | |||
| // Thread stack size should be at least 16KB. The thread struct located at stack bottom, | |||
| // and the mprotect page is located at stack top-end. | |||
| // reserved_space must be <= stack_size / 2 | |||
| thread* thread_create(thread_entry start, void* arg, | |||
There was a problem hiding this comment.
thread_create now able to set THREAD_ENALBE_WORK_STEALING when creating, but still need methods to enable/disable stealing for thread temporary.
lihuiba
force-pushed
the
work-stealing
branch
from
4b830be
to
6e073bd
Compare
lihuiba
force-pushed
the
work-stealing
branch
from
6e073bd
to
e07b13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.