Moss: borrar self._dest en el index #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
En versiones actuales de Git, al agregar un directorio que es a su vez un repo, se crea un "git submodule" en esa ubicación, y nuestro `shutil.rmtree` es insuficiente para remplazarlo. Para cubrir ese caso, este commit añade un `git rm --cached` tras `shutil.rmtree`. (N.B.: no puede usarse `git rm -r`, pues el directorio no aparece en .gitmodules, y el comando da error.)
mbuchwald
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En versiones actuales de Git, al agregar un directorio que es a su vez un repo, se crea un "git submodule" en esa ubicación, y nuestro
shutil.rmtreees insuficiente para remplazarlo. Para cubrir ese caso, este commit añade ungit rm --cachedtrasshutil.rmtree. (N.B.: no puede usarsegit rm -r, pues el directorio no aparece en .gitmodules, y el comando da error.)Este cambio está live en lamport. Podemos hacer merge una vez confirmemos que funciona.