Merge pull request HubSpot#11 from HubSpot/sdk-factory

Move logic of auto-discovering to a Factory Base class
algoretico · Dec 18, 2019 · 170bb3f · 170bb3f
2 parents 5286c18 + ff1a04a
commit 170bb3f
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 56 deletions.
diff --git a/lib/Factory/Base.php b/lib/Factory/Base.php
@@ -0,0 +1,39 @@
+<?php
+
+namespace HubSpot\Factory;
+
+use GuzzleHttp\Client;
+use HubSpot\Client\Crm\Owners\Configuration;
+use ReflectionClass;
+use ReflectionException;
+
+class Base
+{
+    /** @var Client */
+    protected $client;
+
+    /** @var Configuration */
+    protected $config;
+
+    public function __construct($client, $config)
+    {
+        $this->client = $client;
+        $this->config = $config;
+    }
+
+    /**
+     * @param string $name
+     * @param mixed  $args
+     *
+     * @throws ReflectionException
+     *
+     * @return mixed
+     */
+    public function __call($name, $args)
+    {
+        $className = (new ReflectionClass(get_class($this)))->getShortName();
+        $resource = '\\HubSpot\\Client\\Crm\\'.$className.'\\Api\\'.ucfirst($name);
+
+        return new $resource($this->client, $this->config);
+    }
+}
diff --git a/lib/Factory/Objects.php b/lib/Factory/Objects.php
@@ -2,47 +2,19 @@
 
 namespace HubSpot\Factory;
 
-use GuzzleHttp\Client;
 use HubSpot\Client\Crm\Objects\Api\AssociationsApi;
 use HubSpot\Client\Crm\Objects\Api\BasicApi;
 use HubSpot\Client\Crm\Objects\Api\BatchApi;
 use HubSpot\Client\Crm\Objects\Api\CreateNativeObjectsApi;
 use HubSpot\Client\Crm\Objects\Api\SearchApi;
-use HubSpot\Client\Crm\Objects\Configuration;
 
 /**
- * Class Objects.
- *
  * @method AssociationsApi associationsApi()
  * @method BasicApi basicApi
  * @method BatchApi batchApi()
  * @method CreateNativeObjectsApi createNativeObjectsApi
  * @method SearchApi searchApi()
  */
-class Objects
+class Objects extends Base
 {
-    /** @var Client */
-    protected $client;
-
-    /** @var Configuration */
-    protected $config;
-
-    public function __construct($client, $config)
-    {
-        $this->client = $client;
-        $this->config = $config;
-    }
-
-    /**
-     * @param string $name
-     * @param mixed  $args
-     *
-     * @return mixed
-     */
-    public function __call($name, $args)
-    {
-        $resource = '\\HubSpot\\Client\\Crm\\Objects\\Api\\'.ucfirst($name);
-
-        return new $resource($this->client, $this->config);
-    }
 }
diff --git a/lib/Factory/Owners.php b/lib/Factory/Owners.php
@@ -2,37 +2,11 @@
 
 namespace HubSpot\Factory;
 
-use GuzzleHttp\Client;
 use HubSpot\Client\Crm\Owners\Api\DefaultApi;
-use HubSpot\Client\Crm\Owners\Configuration;
 
 /**
  * @method DefaultApi defaultApi()
  */
-class Owners
+class Owners extends Base
 {
-    /** @var Client */
-    protected $client;
-
-    /** @var Configuration */
-    protected $config;
-
-    public function __construct($client, $config)
-    {
-        $this->client = $client;
-        $this->config = $config;
-    }
-
-    /**
-     * @param string $name
-     * @param mixed  $args
-     *
-     * @return mixed
-     */
-    public function __call($name, $args)
-    {
-        $resource = '\\HubSpot\\Client\\Crm\\Owners\\Api\\'.ucfirst($name);
-
-        return new $resource($this->client, $this->config);
-    }
 }