Boxes: Add support for Boxes #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore copied over txt test resource files (#342) * Github-Actions: Adding pr title and label checks (#339) * Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351) * AVM: Consolidate TEAL and AVM versions (#348) * Testing: Modify cucumber steps to use dev mode network (#350) * DevTools: adding source map decoder (#352) * adding source map decoder * Add back line in makefile * Remove redundant mvn test Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Ben Guidarelli <[email protected]>
* Ignore copied over txt test resource files (#342) * Github-Actions: Adding pr title and label checks (#339) * Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351) * AVM: Consolidate TEAL and AVM versions (#348) * Testing: Modify cucumber steps to use dev mode network (#350) * DevTools: adding source map decoder (#352) * adding source map decoder * bump to 1.17.0 * Enhancement: Use Sandbox for Testing (#363) * Bugfix: Pass verbosity to the harness and sandbox (#371) * Enhancement: Deprecating use of langspec (#367) Co-authored-by: Michael Diamant <[email protected]> * StateProofs: Add State Proof support. (#360) * Regenerate client. * Implement cucumber response tests. * Implement path tests, update Makefile, update README. * Revert * Add state proof fields to Transaction. * Update README.md * Update src/main/java/com/algorand/algosdk/transaction/Transaction.java * publish results. * Add transaction-root-256 * dummy commit to avoid check pr category * dummy commit to kill previous dummy commit Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Ben Guidarelli <[email protected]> Co-authored-by: Barbara Poon <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
* indexer model from indexer branch tzaffi/box-search * step in cucumber test to see url query match with expected * minor, better testing script * @unit.applications.boxes * rm unused steps * Update .test-env
* add indexer impl in sdk * merge step for indexer * add indexer confirmed steps * add indexer confirmed steps, working! * add indexer confirmed steps * minor * minor * per new step expectation * unify with applications.boxes * phrasing * refactoring * Update .test-env * minor
ahangsu
reviewed
Sep 15, 2022
jasonpaulos
reviewed
Sep 21, 2022
src/main/java/com/algorand/algosdk/transaction/AppBoxReference.java
Outdated
Show resolved
Hide resolved
src/main/java/com/algorand/algosdk/transaction/Transaction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/algorand/algosdk/transaction/Transaction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/algorand/algosdk/builder/transaction/MethodCallTransactionBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/algorand/algosdk/builder/transaction/ApplicationCallReferencesSetter.java
Outdated
Show resolved
Hide resolved
src/test/java/com/algorand/algosdk/integration/Applications.java
Outdated
Show resolved
Hide resolved
src/test/java/com/algorand/algosdk/integration/Applications.java
Outdated
Show resolved
Hide resolved
| * form 'int:1234'. For raw bytes, use the form 'b64:A=='. For printable strings, | ||
| * use the form 'str:hello'. For addresses, use the form 'addr:XYZ...'. | ||
| */ | ||
| public GetApplicationBoxByName name(String name) { |
There was a problem hiding this comment.
This pattern suffers from the same drawbacks I brought up in algorand/js-algorand-sdk#604 (comment)
Though since this code is generated, I expect we don't want to take any action here at the moment.
There was a problem hiding this comment.
@jasonpaulos Agree - Spent some time here and unfortunately, I don't see a better alternative due to the code generation.
This was referenced Sep 22, 2022
Merged
jasonpaulos
approved these changes
Sep 23, 2022
ahangsu
reviewed
Sep 27, 2022
ahangsu
reviewed
Sep 27, 2022
ahangsu
reviewed
Sep 27, 2022
src/main/java/com/algorand/algosdk/transaction/MethodCallParams.java
Outdated
Show resolved
Hide resolved
ahangsu
approved these changes
Sep 28, 2022
michaeldiamant
changed the title
Regenerate sources from upstream AVM branches
michaeldiamant
commented
Nov 1, 2022
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SDK support for Boxes introduced in algorand/indexer#1168 and algorand/go-algorand#4149.