Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction.equals does not check all fields #403

Open
jasonpaulos opened this issue Sep 23, 2022 · 0 comments
Open

Transaction.equals does not check all fields #403

jasonpaulos opened this issue Sep 23, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers Team Lamprey

Comments

@jasonpaulos
Copy link
Contributor

Problem

The Transaction.equals method checks for equality between two Transaction objects. Currently, many fields from the two transactions are checked, but there is a large number of fields (mostly app call transaction ones) which are NOT currently being checked.

Scope

The Transaction.equals method should check equality by checking all possible transaction fields.

Consider also an automated test which can somehow verify that each transaction field is checked by the equals method.

@algoanne algoanne added the bug Something isn't working label May 9, 2023
@winder winder added the good first issue Good for newcomers label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Team Lamprey
Projects
None yet
Development

No branches or pull requests

3 participants