Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: Add static EnableTelemetry retry #6183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

urtho
Copy link
Contributor

@urtho urtho commented Nov 28, 2024

Remote telemetry with a static URI in config never gets enabled past the initial, single try at algod startup.
Remote logging to static URI never gets enabled in the event the Internet or remote service is not available during Algod startup.

There is no such issue with dynamic remote telemetry (DNS based discovery) as it retries the connection with TelemetryURIUpdateService.

This PR adds a loop that retries the static remote service every minute until it succeeds.

@urtho
Copy link
Contributor Author

urtho commented Nov 28, 2024

This one does not solve the HeartBeat race where HB sometimes is not being sent via telemetry.

Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with adding the go routine loop, but if we're doing that, let's only do that. We can remove the initial attempt to enable, and only enable in the loop.

@urtho
Copy link
Contributor Author

urtho commented Dec 2, 2024

This change will make static telemetry init fully async instead of sync.
Initial Start and HeartBeat events will be lost in most startup cases with static URI - same as it is now with DNS telemetry.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (62f9082) to head (5053e2d).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
cmd/algod/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6183      +/-   ##
==========================================
- Coverage   55.70%   54.90%   -0.81%     
==========================================
  Files         494      494              
  Lines       69972    69976       +4     
==========================================
- Hits        38981    38422     -559     
- Misses      28276    28875     +599     
+ Partials     2715     2679      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants