Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: remove ws net proto 2.1 #6081

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

Remove wsnet proto=2.1 and optional compression since the entire network supports 2.2 and compressed PP messages.
I left couple commented out lines showing how to set and check features.

Test Plan

Existing tests

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.23%. Comparing base (a9c2b7e) to head (39bc6c7).
Report is 10 commits behind head on master.

Files Patch % Lines
network/msgCompressor.go 71.42% 1 Missing and 1 partial ⚠️
network/wsNetwork.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6081      +/-   ##
==========================================
- Coverage   56.26%   56.23%   -0.04%     
==========================================
  Files         488      488              
  Lines       69607    69561      -46     
==========================================
- Hits        39166    39119      -47     
+ Misses      27783    27782       -1     
- Partials     2658     2660       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

network/wsNetwork.go Outdated Show resolved Hide resolved
network/wsPeer.go Show resolved Hide resolved
network/wsNetwork.go Outdated Show resolved Hide resolved
@algorandskiy algorandskiy force-pushed the pavel/wsnet-proto-2.1-removal branch from 1695ce7 to 3ce1bef Compare July 29, 2024 18:02
@algorandskiy algorandskiy requested a review from jasonpaulos July 29, 2024 18:04
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, asked a few questions.

gmalouf
gmalouf previously approved these changes Jul 29, 2024
jasonpaulos
jasonpaulos previously approved these changes Jul 30, 2024
network/wsNetwork.go Outdated Show resolved Hide resolved
network/wsNetwork.go Outdated Show resolved Hide resolved
@algorandskiy algorandskiy dismissed stale reviews from jasonpaulos and gmalouf via b133b24 July 30, 2024 20:01
jasonpaulos
jasonpaulos previously approved these changes Jul 31, 2024
gmalouf
gmalouf previously approved these changes Aug 2, 2024
network/wsNetwork.go Outdated Show resolved Hide resolved
@algorandskiy algorandskiy dismissed stale reviews from gmalouf and jasonpaulos via 39bc6c7 August 8, 2024 17:50
@algorandskiy algorandskiy merged commit 595ec23 into algorand:master Aug 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants