-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: remove ws net proto 2.1 #6081
network: remove ws net proto 2.1 #6081
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6081 +/- ##
==========================================
- Coverage 56.26% 56.23% -0.04%
==========================================
Files 488 488
Lines 69607 69561 -46
==========================================
- Hits 39166 39119 -47
+ Misses 27783 27782 -1
- Partials 2658 2660 +2 ☔ View full report in Codecov by Sentry. |
1695ce7
to
3ce1bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, asked a few questions.
Summary
Remove wsnet proto=2.1 and optional compression since the entire network supports 2.2 and compressed PP messages.
I left couple commented out lines showing how to set and check features.
Test Plan
Existing tests