-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: Add goal node subcommand to generate peer private key #6078
cmd: Add goal node subcommand to generate peer private key #6078
Conversation
f8c6534
to
9b23a43
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6078 +/- ##
==========================================
+ Coverage 55.95% 56.26% +0.30%
==========================================
Files 488 489 +1
Lines 69602 69627 +25
==========================================
+ Hits 38945 39173 +228
+ Misses 27967 27802 -165
+ Partials 2690 2652 -38 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, just one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though it may make sense to move this to be a goal subcommand later, for node operators who want to generate persistent p2p IDs.
Like |
Implemented as |
Summary
As part of upcoming p2p deployment we need to register p2p bootstrap nodes in DNS TXT.
This tool allows to generate a new peer private key and print out peer ID (or print it from existing key file with default name).
Test Plan
Tested manually