Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix state proof e2e test failures #5839

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

Fix test failures after merging #5663
The TestStateProofMessageCommitmentVerification reset a global var config.Consensus and TestStateProofRecovery was not able to find its consensus there.

Test Plan

Tests passed locally

% export NODEBINDIR=~/go/bin
% export TESTDATADIR=`pwd`/test/testdata
% export TESTDIR=/tmp
% make
% go test ./test/e2e-go/features/stateproofs -run '(TestStateProofMessageCommitmentVerification)|(TestStateProofRecovery)$'

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (89a1930) 55.82% compared to head (af5edbf) 55.78%.
Report is 1 commits behind head on master.

Files Patch % Lines
crypto/curve25519.go 33.33% 4 Missing and 4 partials ⚠️
config/consensus.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5839      +/-   ##
==========================================
- Coverage   55.82%   55.78%   -0.05%     
==========================================
  Files         477      477              
  Lines       67238    67256      +18     
==========================================
- Hits        37536    37517      -19     
- Misses      27166    27195      +29     
- Partials     2536     2544       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit fcc686d into algorand:master Nov 18, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants