-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eval: split TestTransactionGroup from BlockEvaluator using TransactionGroupTester #5818
base: master
Are you sure you want to change the base?
Conversation
…ing TestEvalContext
506b9ed
to
b09a797
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5818 +/- ##
==========================================
+ Coverage 54.28% 56.20% +1.91%
==========================================
Files 494 494
Lines 69936 69958 +22
==========================================
+ Hits 37968 39318 +1350
+ Misses 29246 27962 -1284
+ Partials 2722 2678 -44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea, I had small comments, but willing to approve as is.
Summary
eval.TestTransactionGroup (and TestTransaction) need only read-only access to a few details about the next pending block. This introduces an interface TestEvalContext that is used by the transaction pool, so that there can be parallel TX backlog workers checking if transactions are well-formed and move them from the backlogQueue to the postVerificationQueue.
Test Plan
Updated TxHandler test that was checking Remember() vs Test() and counting metrics bumped by different kinds of err returns.