-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Block Generator - allow exporting to files #5714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
changed the title
Tools blockgen file export
tools: Block Generator - allow exporting to files
Aug 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #5714 +/- ##
=======================================
Coverage 55.54% 55.54%
=======================================
Files 476 476
Lines 66853 66853
=======================================
Hits 37131 37131
- Misses 27193 27201 +8
+ Partials 2529 2521 -8 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
requested review from
a team,
winder,
Eric-Warehime,
shiqizng and
algochoi
and removed request for
a team
August 30, 2023 22:01
tzaffi
commented
Aug 30, 2023
tzaffi
commented
Aug 30, 2023
winder
suggested changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall.
shiqizng
previously approved these changes
Sep 5, 2023
winder
approved these changes
Sep 19, 2023
jasonpaulos
approved these changes
Sep 20, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block Generator in File Exporting Mode + README + Makefile + Remove Python Runner
Functional changes
tools/block-generator/generator/server.go
- adding some calling context inmaybeWriteError()
tools/block-generator/runner/run.go
- handle file exporting with a newconduit.yml
templatetools/block-generator/runner/runner.go
- don't enforce the need for a connection string in the case of a file exporterNon functional changes:
Makefile
targets:make pg-up
- standalone docker runmake pg-query
- query postgres (handy since the DB credentials are variables of the Makefile)make run-file-exporter
- runner command tailored for file system exportingmake benchmark-blocks-export
- encapsulates the previous to create blocks with a top-level report directory named according to the scenariomake
targets