Make the pending transaction endpoint notice heartbeats

algorand · Nov 27, 2024 · 521cf5f · 521cf5f
1 parent 3a0abc4
commit 521cf5f
Show file tree

Hide file tree

Showing 4 changed files with 101 additions and 100 deletions.
diff --git a/daemon/algod/api/algod.oas2.json b/daemon/algod/api/algod.oas2.json
@@ -245,7 +245,7 @@
     },
     "/v2/accounts/{address}": {
       "get": {
-        "description": "Given a specific account public key, this call returns the accounts status, balance and spendable amounts",
+        "description": "Given a specific account public key, this call returns the account's status, balance and spendable amounts",
         "tags": [
           "public",
           "nonparticipating"

diff --git a/daemon/algod/api/algod.oas3.yml b/daemon/algod/api/algod.oas3.yml
@@ -2978,7 +2978,7 @@
     },
     "/v2/accounts/{address}": {
       "get": {
-        "description": "Given a specific account public key, this call returns the accounts status, balance and spendable amounts",
+        "description": "Given a specific account public key, this call returns the account's status, balance and spendable amounts",
         "operationId": "AccountInformation",
         "parameters": [
           {

diff --git a/daemon/algod/api/server/v2/generated/nonparticipating/public/routes.go b/daemon/algod/api/server/v2/generated/nonparticipating/public/routes.go
diff --git a/data/transactions/transaction.go b/data/transactions/transaction.go
@@ -325,7 +325,7 @@ func (tx Header) Alive(tc TxnContext) error {
 
 // MatchAddress checks if the transaction touches a given address.
 func (tx Transaction) MatchAddress(addr basics.Address, spec SpecialAddresses) bool {
-	return slices.Contains(tx.RelevantAddrs(spec), addr)
+	return slices.Contains(tx.relevantAddrs(spec), addr)
 }
 
 var errKeyregTxnFirstVotingRoundGreaterThanLastVotingRound = errors.New("transaction first voting round need to be less than its last voting round")
@@ -714,9 +714,8 @@ func (tx Header) Last() basics.Round {
 	return tx.LastValid
 }
 
-// RelevantAddrs returns the addresses whose balance records this transaction will need to access.
-// The header's default is to return just the sender and the fee sink.
-func (tx Transaction) RelevantAddrs(spec SpecialAddresses) []basics.Address {
+// relevantAddrs returns the addresses whose balance records this transaction will need to access.
+func (tx Transaction) relevantAddrs(spec SpecialAddresses) []basics.Address {
 	addrs := []basics.Address{tx.Sender, spec.FeeSink}
 
 	switch tx.Type {
@@ -733,6 +732,8 @@ func (tx Transaction) RelevantAddrs(spec SpecialAddresses) []basics.Address {
 		if !tx.AssetTransferTxnFields.AssetSender.IsZero() {
 			addrs = append(addrs, tx.AssetTransferTxnFields.AssetSender)
 		}
+	case protocol.HeartbeatTx:
+		addrs = append(addrs, tx.HeartbeatTxnFields.HbAddress)
 	}
 
 	return addrs