refactor(vue): replace instantsearch.js with instantsearch-core #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FX-3069] BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c0dcf6:
|
Haroenv
commented
Nov 15, 2024
Haroenv
force-pushed
the
feat/core-migration-vue
branch
from
2ce5ed7
to
f92141f
Compare
Haroenv
requested review from
a team,
dhayab and
shaejaz
and removed request for
a team
dhayab
reviewed
Nov 25, 2024
Comment on lines
+34
to
+38
| if (this.instantSearchInstance.helper) { | ||
| this.instantSearchInstance.helper | ||
| .setIndex(indexName || '') | ||
| .search(); | ||
| } |
There was a problem hiding this comment.
Shouldn't this also manipulates mainHelper until we handle the case in instantsearch-core?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-3069
BREAKING CHANGE: if you are using any internal instantsearch.js functions, ensure to update to instantsearch-core to avoid duplication