Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

[mdanalysis] include new text selectors #4700

Merged
merged 2 commits into from
Oct 6, 2021
Merged

[mdanalysis] include new text selectors #4700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e143e7
[mdanalysis] include new text selectors
orbeckst Oct 6, 2021
b4b3f84
Merge branch 'master' into patch-1
shortcuts Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configs/mdanalysis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
"lvl2": "[itemprop='articleBody'] > .section h3, .page h3, .post h3, .body > .section h3",
"lvl3": "[itemprop='articleBody'] > .section h4, .page h4, .post h4, .body > .section h4",
"lvl4": "[itemprop='articleBody'] > .section h5, .page h5, .post h5, .body > .section h5",
"text": "[itemprop='articleBody'] > .section p, .page p, .post p, .body > .section p, [itemprop='articleBody'] > .section li, .page li, .post li, .body > .section li"
"text": "[itemprop='articleBody'] > .section p, .page p, .post p, .body > .section p, [itemprop='articleBody'] > .section li, .page li, .post li, .body > .section li, [itemprop='articleBody'] > .section dt, .body > .section dt, [itemprop='articleBody'] > .section pre, .page pre, .post pre, .body > .section pre, "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, having this number of selectors could add a lot of noise to the search results and hide other relevant results. A new crawl will be started right after the merge, don't hesitate to revert if you're not happy with the results!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comment @shortcuts .

Most of the selectors were added earlier by @s-pace to properly index our sites. If adding dt and pre to this list creates too much noise we'll take you up on your offer to revert.

Thank you for the opportunity to try it out.

I hope that this also somehow solves #4699 .

},
"conversation_id": [
"569445928"
],
"nb_hits": 32205
}
}