Update Configuration.php #1594
Open
Update Configuration.php #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typecast the $query variable to comply with the PHP 8 standards of [html_entity_decode](https://www.php.net/manual/en/function.html-entity-decode.php) If the search results page (`/catalogsearch/result`) is requested and the `q` query parameter is not present the page will error. The code errors when generating the `algoliaConfig` JS variable which means that Algolia can not be instantiated. This means no products show on the page - the expected result is that a blank search query would be performed and thus a set of products would be displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the search results page (
/catalogsearch/result) is requested and theqquery parameter is not present the page will error. The code errors when generating thealgoliaConfigJS variable which means that Algolia can not be instantiated. This means no products show on the page - the expected result is that a blank search query would be performed and thus a set of products would be displayed.Result
Visit
/catalogsearch/resultand observe that this error is thrown in the Magentovar/log/system.loglog file.This results in a broken page.
With this change implemented, the page loads products and no error is thrown.
Explanation
typecast the $query variable to comply with the PHP 8 standards of html_entity_decode
Tested On