fix(saveObjects-error-msg): refine the error thrown by the method #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloelbn
commented
Sep 9, 2019
chloelbn
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related Issue | Fix #583 |
| Need Doc update | no |
nunomaduro
suggested changes
Sep 9, 2019
nunomaduro
suggested changes
Sep 9, 2019
src/Support/Helpers.php
Outdated
| */ | ||
| public static function isIterable($object) | ||
| { | ||
| return is_array($object) || is_object($object) || $object instanceof \Traversable; |
There was a problem hiding this comment.
Can you explain me is_object($object)?
There was a problem hiding this comment.
I wanted to cover the maximum cases where a given variable is foreachable, and objects as arrays don't implement the Traversable interface. cf https://www.php.net/manual/en/class.traversable.php
There was a problem hiding this comment.
Yes, but objects are foreachable if they implement ArrayAccess interface. Correct? They ArrayAccess interface return true on is_array. No ?
nunomaduro
previously approved these changes
Sep 10, 2019
chloelbn
force-pushed
the
fix/saveobjects-error-msg
branch
from
7f476f3
to
6775654
Compare
nunomaduro
suggested changes
Sep 24, 2019
chloelbn
force-pushed
the
fix/saveobjects-error-msg
branch
from
6775654
to
57dc870
Compare
nunomaduro
force-pushed
the
fix/saveobjects-error-msg
branch
from
57dc870
to
3a08a88
Compare
|
Putting this on hold, waiting for Chloe for this. |
hc0503
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.