Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graphql language #185

Merged

Conversation

nicolae-stroncea
Copy link
Contributor

@nicolae-stroncea nicolae-stroncea commented Jul 24, 2021

Closes #171.

Highlight.js does not add new languages anymore, and instead encourages 3rd parties to develop their own packages that they will link to from here Supported Languages.

From the official docs:

Sadly, due to lack of maintainer time we no longer merge new languages grammars into the core library. Instead, the project works by encouraging 3rd party language grammar development by willing contributors ready to help and maintain them.

Therefore, to add support in code-blocks for new languages, packages for those languages will have to be explicitly pulled.

In this PR I've defined a function in which other languages can also be added in the future, add added graphql in there.

client/sidebar.js Outdated Show resolved Hide resolved
@amomchilov
Copy link
Contributor

@alexwforsythe Any chance you can take a look into merging this?

@awx-josh-fu
Copy link

Please, I need this!

Copy link
Owner

@alexwforsythe alexwforsythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- will approve once the formatting & naming comments are addressed!

client/sidebar.js Outdated Show resolved Hide resolved
@va3093
Copy link

va3093 commented Aug 3, 2022

V pumped for this.

@alexwforsythe alexwforsythe merged commit c79121e into alexwforsythe:master Aug 3, 2022
@amomchilov
Copy link
Contributor

amomchilov commented Aug 5, 2022

@alexwforsythe Hey Alex, do you have any plans for when you'd cut a new release that contains this?

Funny enough, I have a tech design review on Monday, I would love to format my GraphQL blocks for it :D

@nicolae-stroncea
Copy link
Contributor Author

nicolae-stroncea commented Aug 6, 2022

on the subject, #216 needs to be approved for this PR to work correctly as currently the name of the function we're calling is different from the name of the function we wrote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for GraphQL syntax
6 participants