iter23 #22
Merged
iter23 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinsoe
suggested changes
Nov 19, 2023
| if cfg.ConfigPath != "" { | ||
| cfgJSON, err := readConfigFile(cfg.ConfigPath) | ||
| if err != nil { | ||
| return cfgJSON, err |
There was a problem hiding this comment.
Не совсем соответствует заданию. Конфигурация из JSON имеет наименьший приоритет.
internal/pkg/middleware/crypt.go
Outdated
| return | ||
| } | ||
|
|
||
| privateKeyPEM, err := os.ReadFile(privateKeyPath) |
There was a problem hiding this comment.
На каждый запрос заново читать и парсить ключи кажется избыточным.
Лучше делать это однажды при старте приложения, а если мы ожидаем, что они будут меняться во время приложения - делать механизм "перечитывания" конфигурации.
internal/pkg/agent/encrypt.go
Outdated
| ) | ||
|
|
||
| func encrypt(publicKeyPath string, data []byte) ([]byte, error) { | ||
| publicKeyPEM, err := os.ReadFile(publicKeyPath) |
There was a problem hiding this comment.
Тут такая же проблема как в декрипте - каждый раз заново читать файл плохо.
internal/pkg/agent/reporter.go
Outdated
| return false, fmt.Errorf("error create post request %w", err) | ||
| } | ||
| return true, nil | ||
| } | ||
|
|
||
| func SendBatchJSON(url string, metricsBatch []*metrics.Metrics, signKey []byte) error { | ||
| func SendBatchJSON(url string, metricsBatch []*metrics.Metrics, signKey []byte, publicKey string) error { |
There was a problem hiding this comment.
Не предлагаю это сейчас исправлять. Но кажется архитектурно не самый удачный подход передавать столько параметров. Можно настроить объект и передавать ему при каждом вызове только меняющиеся данные(метрики)
valentinsoe
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.