src: fix write after end of buffer

we hardcode `sock->buf[num_read] = '\0';` so num_read cannot be equal to the size of the buffer. Signed-off-by: Giuseppe Scrivano <[email protected]>
alexlarsson · Nov 30, 2023 · 3605a36 · 3605a36
1 parent 633ac6b
commit 3605a36
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/conn_sock.c b/src/conn_sock.c
@@ -416,7 +416,7 @@ static gboolean read_remote_sock(struct remote_sock_s *sock)
 	}
 
 	if (SOCK_IS_STREAM(sock->sock_type)) {
-		num_read = read(sock->fd, sock->buf, CONN_SOCK_BUF_SIZE);
+		num_read = read(sock->fd, sock->buf, CONN_SOCK_BUF_SIZE - 1);
 	} else {
 		num_read = recvfrom(sock->fd, sock->buf, CONN_SOCK_BUF_SIZE - 1, 0, NULL, NULL);
 	}