Person list #45
Closed
Person list #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkramer
reviewed
Sep 19, 2016
| <mdl-textfield floating-label="Birth Year" :value.sync="personData.birth_year"></mdl-textfield> | ||
| <mdl-textfield floating-label="Gender" :value.sync="personData.gender"></mdl-textfield> | ||
| <div class="mdl-card__actions"> | ||
| <div class="mdl-textfield mdl-js-textfield mdl-textfield--floating-label is-upgraded is-dirty"> |
There was a problem hiding this comment.
is-updgraded and is-dirty are dynamic classes that should be added by mdl once you make a call to the component handler to upgrade the elements
| <select class="full-width-select" | ||
| name="person-select" | ||
| v-model="idForName" | ||
| v-on:change="fetchPerson"> |
There was a problem hiding this comment.
Can you the shorthand @change here instead of v-on:change
| this.loading = true; | ||
| this.imageShow = false; | ||
| this.personImageMsg = ''; | ||
| const randomPersonId = Math.floor((Math.random() * 87) + 1); | ||
| person.fetch(randomPersonId).then((personData) => { | ||
| person.fetch(this.idForName).then((personData) => { |
There was a problem hiding this comment.
Should not need the parens around personData
| name="person-select" | ||
| v-model="idForName" | ||
| v-on:change="fetchPerson"> | ||
| <option v-for="option in nameList" v-bind:value="option.value"> |
There was a problem hiding this comment.
v:bind:value is the long form. Can use just :value
| person.fetchPage = (resolve, pageNumber) => { | ||
| const pageToGet = `${personBaseUrl}?page=${pageNumber}`; | ||
| Vue.http.get(pageToGet).then(response => { | ||
| for (const result of response.data.results) { |
There was a problem hiding this comment.
Could use an object with a constructor to encapsulate this logic and move it to a testable unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of all people for issue #12
I initially tried using mdl-select from vue-mdl, but that component is fairly buggy. I ran into posva/vue-mdc#46 and also there seem to be some deeper problems with data binding.
Anyway, I switched to a regular select which works fine.