Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Bloom Filter data structure #65

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

rsclip
Copy link
Contributor

@rsclip rsclip commented Dec 29, 2023

Created a (somewhat-heavily) documented Bloom Filter probabilistic data structure implementation.

Adds the BitVec 1.0.1 dependency; improved memory and codegen efficiency. The alternative is a simple Vec<bool> which is not as optimised.

alexfertel
alexfertel previously approved these changes Dec 30, 2023
Copy link
Owner

@alexfertel alexfertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful implementation! Thanks for contributing!

I only have two minor nitpicks, but otherwise LGTM.

The first nitpick is that all comments should end with dots.

);
}

/// more extensive test and contains test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
/// more extensive test and contains test

@alexfertel alexfertel merged commit 22a1e7e into alexfertel:main Dec 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants