Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified the function to take slices as input and return a vector without the need to create and manipulate additional Vec instances. #59

Merged
merged 1 commit into from
Jul 27, 2023
Merged

modified the function to take slices as input and return a vector without the need to create and manipulate additional Vec instances. #59

merged 1 commit into from
Jul 27, 2023

Conversation

abeybernard
Copy link
Contributor

No description provided.

alexfertel
alexfertel approved these changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@alexfertel alexfertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! ❤️

Looks great! Indeed I think this looks cleaner, more idiomatic and easier to read.

@alexfertel alexfertel merged commit c9a3ea6 into alexfertel:main Jul 27, 2023
3 checks passed
@alexfertel
Copy link
Owner

@abeybernard just noticed a typo in your configured git email: <[email protected]>. It's missing the l of gmail.

@abeybernard
Copy link
Contributor Author

abeybernard commented Jul 28, 2023 via email

@alexfertel
Copy link
Owner

Oh, no worries! Happy to help 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfertel alexfertel alexfertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeybernard @alexfertel