Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow IPv6 addresses for --ip and --server args #441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xvzf
Copy link

@xvzf xvzf commented Aug 26, 2024

partially fixes #398 (though with auto-discovery and without flags). This still requires a dual-stack setup on the nodes until Github is finally reachable on the modern internet ;-)

Signed-off-by: Matthias Riegler [email protected]

Why do you need this?

Bootstrapping dual-stack clusters with IPv6 node addresses

How Has This Been Tested?

Bringing ip a dual-stack cluster and setting --ip=... to an IPv6 address

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • x ] I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Riegler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IPv6 addresses
1 participant