-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cnpg plugin for kubectl #865
Conversation
@Jasstkn could you help out here with explaining how to do the checker script that shows the arch for each binary? The one we have in the contributing guide. |
@sxd Hi! thanks for the contribution. Please, check our contribution guide to see how the code should be properly tested. ./hack/test-tool.sh <tool_name> The output of this should be added to the PR's description. It will speed up the review process 🚀 |
@alexellis @Jasstkn working on it! thank you!!! and sorry for wasting your time I thought that I followed all the contribution guide but clearly I didn't, my bad! fixing! |
@Jasstkn here is the output:
I ran
I think it's not related but it's looking for a file that doesn't exists here:
|
The e2e tests were failing but are now fixed in the master branch. @Jasstkn can you give a review when you have time? |
Add the cnpg plugin for kubectl to be used with CloudNativePG operator Signed-off-by: Jonathan Gonzalez V <[email protected]>
I just rebased the PR on master branch so now it shouldn't fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We just missed the update to the README which is part of the PR template. You checked it but I don't think you added the file?
|
I'll sort out the README for you. Thanks for contributing to arkade and for being a sponsor too. |
Add the cnpg plugin for kubectl to be used with CloudNativePG operator
Description
This PR aims to add the cnpg pluging for kubectl to be used with CloudNativePG operator, in a future
PR we hope to provide also a way to install this operator using arkade
Motivation and Context
The cnpg plugin can make use of Arkade to distribute the plugin
Issue #852
How Has This Been Tested?
Local laptop using amd64 and RaspberryPi B4 both to install the plugin both with Linux
Local laptop using amd64 with macOS
Are you a GitHub Sponsor yet (Yes/No?)
Types of changes
Documentation
./arkade get -o markdown
./arkade install --help
Checklist:
git commit -s