Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system app for CNI plugins #674

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Add system app for CNI plugins #674

merged 3 commits into from
Apr 10, 2022

Conversation

alexellis
Copy link
Owner

Description

Add system app for CNI plugins

Motivation and Context

Required for #654

How Has This Been Tested?

go build && sudo ./arkade system install prometheus
Installing Prometheus to /usr/local/bin
Installing version: v2.34.0 for: amd64
Downloading from: https://github.com/prometheus/prometheus/releases/download/v2.34.0/prometheus-2.34.0.linux-amd64.tar.gz
72.77 MiB / 72.77 MiB [--------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
Downloaded to: /tmp/prometheus-2.34.0.linux-amd64.tar.gz
Unpacking binaries to: /tmp/prometheus2922357963
Copying binaries to: /usr/local/bin

sudo chmod +x /usr/local/bin/prometheus 

/usr/local/bin/prometheus --version
prometheus, version 2.34.0 (branch: HEAD, revision: 881111fec4332c33094a6fb2680c71fffc427275)
  build user:       root@121ad7ea5487
  build date:       20220315-15:18:00
  go version:       go1.17.8
  platform:         linux/amd64

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

App still needs adding to README, along with others added recently.

Part of the changes in: #654

Tested on a Linux AMD64 host, downloaded as expected.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Makes the app more consistent with others

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Without this setting, chmod is required later on.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
@alexellis alexellis merged commit f3810b3 into master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant