Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arch flag to prometheus install #673

Merged
merged 1 commit into from
Apr 10, 2022
Merged

feat: add arch flag to prometheus install #673

merged 1 commit into from
Apr 10, 2022

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Apr 10, 2022

Signed-off-by: Engin Diri [email protected]

Description

Motivation and Context

How Has This Been Tested?

root@bf0e69bea5a6:/workspace# ./arkade system install prometheus --arch amd64
Installing Prometheus to /usr/local/bin
Installing version: v2.34.0 for: amd64
Downloading from: https://github.com/prometheus/prometheus/releases/download/v2.34.0/prometheus-2.34.0.linux-amd64.tar.gz
72.77 MiB / 72.77 MiB [--------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
Downloaded to: /tmp/prometheus-2.34.0.linux-amd64.tar.gz
Unpacking binaries to: /tmp/prometheus4128823328
Copying binaries to: /usr/local/bin
root@bf0e69bea5a6:/workspace# 

Are you a GitHub Sponsor (Yes/No?)

  • Yes
  • No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 627b9f6 into alexellis:master Apr 10, 2022
@dirien dirien deleted the prom_arch branch April 10, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants