Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend kubetrim to access compressed binaries #1116

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Sep 5, 2024

Description

Kubetrim has been amended to provide binaries in a compressed form in much the same way as inlets.

This change adjusts the kubetrim template to access the .tgz versions.

Motivation and Context

Kubetrim has been amended to provide binaries in a compressed form in much the same way as inlets.

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

make e2e and test-tool will fail until the merge on the kubetrim side produces appropriate binaries

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Maintenance

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I've read the CONTRIBUTION guide
  • [ x] I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

@alexellis alexellis marked this pull request as ready for review September 9, 2024 14:17
@alexellis alexellis merged commit d3025ca into alexellis:master Sep 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants