Move upgradeable check to using semVer/pre #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of tag version edge cases requiring exception from being upgraded was increasing to the point where constantly adding to the exception list was no longer a viable approach. This change alters how the upgradability of a tag is assessed by parsing the current and latest tags into SemVers and then assessing the `pre` field of the version to determine whether either of the tags are a special case. In order to achieve this it is necessary to move `latest` out to be a case all of itself as this would not be nicely handled by NewVersion(). Signed-off-by: Richard Gee <[email protected]>
alexellis
reviewed
Aug 8, 2024
cmd/chart/upgrade.go
Outdated
| currentSemVer, _ := semver.NewVersion(currentTag) | ||
| latestSemVer, _ := semver.NewVersion(latestTag) | ||
|
|
||
| return latestTag != currentTag && len(latestSemVer.Prerelease()) == 0 && len(currentSemVer.Prerelease()) == 0 |
There was a problem hiding this comment.
What about the case where the value is v0.15.1-rootless and we want to go up to v0.15.2-rootless?
There was a problem hiding this comment.
That will not upgrade.
To achieve that we would need to check that the current/latest prereleases match.
Signed-off-by: Richard Gee <[email protected]>
Signed-off-by: Richard Gee <[email protected]>
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The number of tag version edge cases requiring exception from being upgraded was increasing to the point where constantly adding to the exception list was no longer a viable approach.
This change alters how the upgradability of a tag is assessed by parsing the current and latest tags into SemVers and then assessing the
prefield of the version to determine whether either of the tags are a special case. In order to achieve this it is necessary to movelatestout to be a case all of itself as this would not be nicely handled by NewVersion().Motivation and Context
design/approvedby a maintainer (required)How Has This Been Tested?
Unit only.
If updating or adding a new CLI to
arkade get, run:Types of changes
Documentation
./arkade get --format markdown./arkade install --helpChecklist:
git commit -s