Skip to content

Commit

Permalink
Fix viddy failing app
Browse files Browse the repository at this point in the history
The project made a breaking change to remove the version
from the download filename.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
  • Loading branch information
alexellis committed Aug 29, 2023
1 parent c8cde14 commit 8965ff8
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
3 changes: 3 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,16 @@ require (
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/klauspost/compress v1.16.7 // indirect
github.com/kr/pretty v0.3.1 // indirect
github.com/kr/text v0.2.0 // indirect
github.com/magefile/mage v1.14.0 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.19 // indirect
github.com/mattn/go-runewidth v0.0.15 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.1.0-rc4 // indirect
github.com/rivo/uniseg v0.4.4 // indirect
github.com/rogpeppe/go-internal v1.9.0 // indirect
github.com/sirupsen/logrus v1.9.3 // indirect
github.com/spf13/pflag v1.0.5 // indirect
github.com/vbatts/tar-split v0.11.5 // indirect
Expand Down
10 changes: 5 additions & 5 deletions pkg/get/get_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5205,31 +5205,31 @@ func Test_DownloadViddy(t *testing.T) {
os: "darwin",
arch: arch64bit,
version: version,
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_0.3.6_Darwin_x86_64.tar.gz",
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Darwin_x86_64.tar.gz",
},
{
os: "darwin",
arch: archDarwinARM64,
version: version,
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_0.3.6_Darwin_arm64.tar.gz",
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Darwin_arm64.tar.gz",
},
{
os: "linux",
arch: arch64bit,
version: version,
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_0.3.6_Linux_x86_64.tar.gz",
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Linux_x86_64.tar.gz",
},
{
os: "linux",
arch: archARM64,
version: version,
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_0.3.6_Linux_arm64.tar.gz",
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Linux_arm64.tar.gz",
},
{
os: "ming",
arch: arch64bit,
version: version,
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_0.3.6_Windows_x86_64.tar.gz",
url: "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Windows_x86_64.tar.gz",
},
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/get/tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -3082,7 +3082,7 @@ https://github.com/{{.Owner}}/{{.Repo}}/releases/download/{{.Version}}/{{.Repo}}
{{$osStr = "Darwin"}}
{{- end -}}
{{.Name}}_{{.VersionNumber}}_{{$osStr}}_{{$arch}}.{{$ext}}
{{.Name}}_{{$osStr}}_{{$arch}}.{{$ext}}
`,
})

Expand Down
6 changes: 6 additions & 0 deletions vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ github.com/klauspost/compress/zstd
github.com/klauspost/compress/zstd/internal/xxhash
# github.com/kr/pretty v0.3.1
## explicit; go 1.12
# github.com/kr/text v0.2.0
## explicit
# github.com/magefile/mage v1.14.0
## explicit; go 1.12
# github.com/mattn/go-colorable v0.1.13
## explicit; go 1.15
github.com/mattn/go-colorable
Expand Down Expand Up @@ -115,6 +119,8 @@ github.com/pkg/errors
# github.com/rivo/uniseg v0.4.4
## explicit; go 1.18
github.com/rivo/uniseg
# github.com/rogpeppe/go-internal v1.9.0
## explicit; go 1.17
# github.com/sethvargo/go-password v0.2.0
## explicit; go 1.14
github.com/sethvargo/go-password/password
Expand Down

0 comments on commit 8965ff8

Please sign in to comment.