Skip to content

Commit

Permalink
More review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alexcrichton committed Feb 12, 2024
1 parent a712e0b commit e323597
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/fuzz-stats/src/bin/failed-instantiations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ impl State {
config.gc_enabled = false;

let mut wasm = wasm_smith::Module::new(config, &mut u)?;
wasm.ensure_termination(10_000);
wasm.ensure_termination(10_000).unwrap();
let wasm = wasm.to_bytes();

// We install a resource limiter in the store which limits the store to
Expand Down
2 changes: 1 addition & 1 deletion crates/wit-parser/src/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ impl Resolve {
#[cfg(feature = "wat")]
let is_wasm = wat::Detect::from_bytes(&contents).is_wasm();
#[cfg(not(feature = "wat"))]
let is_wasm = wasmparser::Parser::is_core_wasm(&contents);
let is_wasm = wasmparser::Parser::is_component(&contents);

if is_wasm {
#[cfg(feature = "wat")]
Expand Down
3 changes: 2 additions & 1 deletion src/bin/wasm-tools/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,8 @@ impl SemverCheckOpts {
}

fn run(self) -> Result<()> {
let (resolve, package_id) = parse_wit_from_path(&self.wit)?;
let mut resolve = Resolve::default();
let package_id = resolve.push_path(&self.wit)?.0;
let prev = resolve.select_world(package_id, Some(&self.prev))?;
let new = resolve.select_world(package_id, Some(&self.new))?;
wit_component::semver_check(resolve, prev, new)?;
Expand Down

0 comments on commit e323597

Please sign in to comment.