Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder #53

Open
wants to merge 10 commits into
base: mainline
Choose a base branch
from
Open

Reorder #53

wants to merge 10 commits into from

Conversation

JakeMKelly
Copy link

@sebsto
Copy link
Contributor

sebsto commented Jan 23, 2018

Hello @JakeMKelly

Thank you for proposing all these changes and improving the documentation.
Unfortunately, there are a lot of merge conflicts since you submitted this PR.

Would you mind considering sending smaller PRs that we can easily merge to the main branch ?
I would suggest
a/ to make distinct PR for the multi stream and single stream example
b/ do not rename directories on the single stream project (I know I am not respecting the default for ASK CLI but it matches the default structure of VSCode :-) )
c/ make distinct PRs for doc and code change.

I really appreciate the extra doc you wrote and the ASK CLI migration effort and would love to have these included in the main repo.

Let me know how best you think we can move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants