Bump versions of ftm, ftm-store and servicelayer #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not sure about dataset, but followthemoney and followthemoney-store are also installed directly e.g. in our pipelines image, so pinning them to an exact version will likely make it cumbersome to upgrade these versions independently from Memorious. Sometimes it’s important to be able to quickly bump e.g. the FtM version to make use of a new schema from the default model.
setup.py
Outdated
| "tabulate", | ||
| "python-dateutil >= 2.8.2, < 3.0.0", | ||
| "dataset >= 1.0.8", | ||
| "servicelayer[google,amazon] == 1.20.7", | ||
| "dataset == 1.6.2", |
There was a problem hiding this comment.
Suggested change
| "dataset == 1.6.2", | |
| "dataset >= 1.6.2", |
setup.py
Outdated
| "pantomime == 0.5.1", | ||
| "alephclient >= 2.3.5", | ||
| "followthemoney >= 2.3.1", | ||
| "followthemoney-store >= 3.0.1", | ||
| "followthemoney == 3.5.2", |
There was a problem hiding this comment.
Suggested change
| "followthemoney == 3.5.2", | |
| "followthemoney >= 3.5.2", |
setup.py
Outdated
| "followthemoney >= 2.3.1", | ||
| "followthemoney-store >= 3.0.1", | ||
| "followthemoney == 3.5.2", | ||
| "followthemoney-store == 3.0.6", |
There was a problem hiding this comment.
Suggested change
| "followthemoney-store == 3.0.6", | |
| "followthemoney-store >= 3.0.6", |
…t instead of fixed
catileptic
force-pushed
the
chrome/bump-versions
branch
from
8755a7e
to
275601b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datasetto the latest versionmemoriousrun with the versions as they currently are in this PR, against a PostgreSQL databaseftm,ftm-storeandservicelayerhave been bumped to their latest version that makes them backwards and forwards compatible withSQLAlchemy1.4.49and2+. This is needed in order formemoriousto be able to use the latest version ofdatasetwhich hasn't been refactored to useSQLAlchemy 2+yetbanalandnormalityto the latest versions, to match the versions used inftm,ftm-storeandservicelayer