This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Integrate aldryn-categories into aldryn-jobs. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the README is going to need to be updated for the extra dependency: aldryn_categories. |
| - TOX_ENV=py27-dj16 | ||
| - TOX_ENV=py27-dj17 | ||
| - TOX_ENV=py27-django16 | ||
| - TOX_ENV=py27-django17 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To integrate aldryn-categories I created a model to store Jobs options for categories with category field as a OneToOne relation to aldryn_categories.Category. This is necessary because a bug in treebeard [1] that blocks multi-table inheritance from work.
Aldryn Categories is also used with a ForeignKey field in JobOffers. Because these new fields this pull request depends of aldryn-categories pull request that adds this fields [2].
[1] http://code.tabo.pe/django-treebeard/issue/80/get_result_class-when-creating-new-object
[2] divio/aldryn-categories#9
Note: there is no PEP8 fix on this branch yet, this will be next step :).