Skip to content

Commit

Permalink
Upgrade the Windows sdk
Browse files Browse the repository at this point in the history
been a very long time
  • Loading branch information
aldelaro5 committed Mar 12, 2021
1 parent 7d2c7d8 commit fbc18a0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Before proceeding, ensure the Qt submodule is initialized by running `git submod
Once complete, open the solution file `Dolphin-memory-engine.sln` located in the `Source` directory with Visual Studio. Select the build configuration and build it.

#### Windows SDK
The Windows SDK version 10.0.16299.0 comes with the C++ Desktop Development Workload of Visual Studio 2017 — other versions may work but are untested. To use a different Windows SDK you'll need to select the it in the project properties window. Please note that this will change the `vcxproj` file, so if you plan to submit a Pull Request, make sure to not stage this change.
The Windows SDK version 10.0.19041.0 comes with the C++ Desktop Development Workload of Visual Studio 2017 — other versions may work but are untested. To use a different Windows SDK you'll need to select the it in the project properties window. Please note that this will change the `vcxproj` file, so if you plan to submit a Pull Request, make sure to not stage this change.


### Linux
Expand Down
6 changes: 2 additions & 4 deletions Source/Dolphin-memory-engine.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>15.0</VCProjectVersion>
<ProjectGuid>{FB0FF455-327C-4FCF-B234-A60D8AA9FDDD}</ProjectGuid>
<RootNamespace>Dolphinmemoryengine</RootNamespace>
<WindowsTargetPlatformVersion>10.0.16299.0</WindowsTargetPlatformVersion>
<WindowsTargetPlatformVersion>10.0.19041.0</WindowsTargetPlatformVersion>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<Import Project="Dolphin-memory-engine.default.props" />
Expand Down Expand Up @@ -78,7 +78,6 @@
<SubSystem>Windows</SubSystem>
</Link>
</ItemDefinitionGroup>

<!-- Files and target to copy to the output directory -->
<PropertyGroup>
<!--
Expand All @@ -100,10 +99,9 @@
</ItemGroup>
<Target Name="CopyDlls" AfterTargets="Build">
<Message Importance="High" Text="Copying required files for $(Configuration)..." />
<Message Importance="High" Text="Copying '%(FilesToCopy.FullPath)' -> '$(OutDir)%(FilesToCopy.SubDir)%(Filename)%(Extension)'." />
<Message Importance="High" Text="Copying '%(FilesToCopy.FullPath)' -&gt; '$(OutDir)%(FilesToCopy.SubDir)%(Filename)%(Extension)'." />
<Copy SourceFiles="@(FilesToCopy)" DestinationFiles="$(OutDir)%(FilesToCopy.SubDir)%(Filename)%(Extension)" />
</Target>

<!-- Files -->
<ItemGroup>
<ClCompile Include="**\*.cpp" Exclude="GeneratedFiles\**\*.cpp" />
Expand Down

0 comments on commit fbc18a0

Please sign in to comment.