feat: add more SD tests

aldbr · Dec 8, 2023 · fdab2a1 · fdab2a1
1 parent e8e4ef8
commit fdab2a1
Show file tree

Hide file tree

Showing 22 changed files with 538 additions and 471 deletions.
diff --git a/docs/source/UserGuide/WebPortalReference/PilotMonitor/index.rst b/docs/source/UserGuide/WebPortalReference/PilotMonitor/index.rst
@@ -90,9 +90,6 @@ The following columns are provided:
 **Benchmark**
     Estimation of the power of the Worker Node CPU which is running the Pilot Job. If 0, the estimation was not possible.
 
-**TaskQueueID**
-    Internal DIRAC WMS identifier of the Task Queue for which the Pilot Job is sent.
-
 **PilotID**
     Internal DIRAC WMS Pilot Job identifier
 

diff --git a/src/DIRAC/ConfigurationSystem/Client/Helpers/Resources.py b/src/DIRAC/ConfigurationSystem/Client/Helpers/Resources.py
@@ -252,10 +252,7 @@ def getQueues(siteList=None, ceList=None, ceTypeList=None, community=None, tags=
         for site in sites:
             if siteList and site not in siteList:
                 continue
-            if community:
-                comList = gConfig.getValue(f"/Resources/Sites/{grid}/{site}/VO", [])
-                if comList and community.lower() not in [cl.lower() for cl in comList]:
-                    continue
+
             siteCEParameters = {}
             result = gConfig.getOptionsDict(f"/Resources/Sites/{grid}/{site}/CEs")
             if result["OK"]:
@@ -272,10 +269,7 @@ def getQueues(siteList=None, ceList=None, ceTypeList=None, community=None, tags=
                         continue
                 if ceList and ce not in ceList:
                     continue
-                if community:
-                    comList = gConfig.getValue(f"/Resources/Sites/{grid}/{site}/CEs/{ce}/VO", [])
-                    if comList and community.lower() not in [cl.lower() for cl in comList]:
-                        continue
+
                 ceOptionsDict = dict(siteCEParameters)
                 result = gConfig.getOptionsDict(f"/Resources/Sites/{grid}/{site}/CEs/{ce}")
                 if not result["OK"]:
@@ -287,9 +281,23 @@ def getQueues(siteList=None, ceList=None, ceTypeList=None, community=None, tags=
                 queues = result["Value"]
                 for queue in queues:
                     if community:
-                        comList = gConfig.getValue(f"/Resources/Sites/{grid}/{site}/CEs/{ce}/Queues/{queue}/VO", [])
+                        # Community can be defined on site, CE or queue level
+                        paths = [
+                            f"/Resources/Sites/{grid}/{site}/CEs/{ce}/Queues/{queue}/VO",
+                            f"/Resources/Sites/{grid}/{site}/CEs/{ce}/VO",
+                            f"/Resources/Sites/{grid}/{site}/VO",
+                        ]
+
+                        # Try each path in order, stopping when we find a non-empty list
+                        for path in paths:
+                            comList = gConfig.getValue(path, [])
+                            if comList:
+                                break
+
+                        # If we found a list and the community is not in it, skip this iteration
                         if comList and community.lower() not in [cl.lower() for cl in comList]:
                             continue
+
                     if tags:
                         queueTags = gConfig.getValue(f"/Resources/Sites/{grid}/{site}/CEs/{ce}/Queues/{queue}/Tag", [])
                         queueTags = set(ceTags + queueTags)

diff --git a/src/DIRAC/Interfaces/scripts/dirac_admin_get_job_pilots.py b/src/DIRAC/Interfaces/scripts/dirac_admin_get_job_pilots.py
@@ -16,8 +16,7 @@
                                                           'PilotJobReference': 'https://marlb.in2p3.fr:9000/biq6KT45Q',
                                                           'PilotStamp': '',
                                                           'Status': 'Done',
-                                                          'SubmissionTime': datetime.datetime(2011, 2, 21, 12, 27, 52),
-                                                          'TaskQueueID': 399L}}
+                                                          'SubmissionTime': datetime.datetime(2011, 2, 21, 12, 27, 52)}}
 """
 from DIRAC.Core.Base.Script import Script
 

diff --git a/src/DIRAC/Interfaces/scripts/dirac_admin_get_pilot_info.py b/src/DIRAC/Interfaces/scripts/dirac_admin_get_pilot_info.py
@@ -15,8 +15,7 @@
                                                           'PilotJobReference': 'https://marlb.in2p3.fr:9000/2KHFrQjkw',
                                                           'PilotStamp': '',
                                                           'Status': 'Done',
-                                                          'SubmissionTime': datetime.datetime(2011, 2, 21, 12, 27, 52),
-                                                          'TaskQueueID': 399L}}
+                                                          'SubmissionTime': datetime.datetime(2011, 2, 21, 12, 27, 52)}}
 """
 from DIRAC.Core.Base.Script import Script
 

diff --git a/src/DIRAC/MonitoringSystem/Client/Types/PilotsHistory.py b/src/DIRAC/MonitoringSystem/Client/Types/PilotsHistory.py
@@ -17,15 +17,14 @@ def __init__(self):
 
         super().__init__()
 
-        self.keyFields = ["TaskQueueID", "GridSite", "GridType", "Status"]
+        self.keyFields = ["GridSite", "GridType", "Status"]
 
         self.monitoringFields = ["NumOfPilots"]
 
         self.index = "pilotshistory_index"
 
         self.addMapping(
             {
-                "TaskQueueID": {"type": "keyword"},
                 "GridSite": {"type": "keyword"},
                 "GridType": {"type": "keyword"},
                 "Status": {"type": "keyword"},

diff --git a/src/DIRAC/Resources/Computing/AREXComputingElement.py b/src/DIRAC/Resources/Computing/AREXComputingElement.py
@@ -618,7 +618,11 @@ def getCEStatus(self):
             self.log.error("Failed getting the status of the CE.", result["Message"])
             return S_ERROR("Failed getting the status of the CE")
         response = result["Value"]
-        ceData = response.json()
+        try:
+            ceData = response.json()
+        except requests.JSONDecodeError:
+            self.log.exception("Failed decoding the status of the CE")
+            return S_ERROR(f"Failed decoding the status of the CE")
 
         # Look only in the relevant section out of the headache
         queueInfo = ceData["Domains"]["AdminDomain"]["Services"]["ComputingService"]["ComputingShare"]

diff --git a/src/DIRAC/Resources/Computing/CloudComputingElement.py b/src/DIRAC/Resources/Computing/CloudComputingElement.py
@@ -355,7 +355,7 @@ def _getMetadata(self, executableFile, pilotStamp=""):
             template = yaml.safe_load(template_fd)
         for filedef in template["write_files"]:
             if filedef["content"] == "PROXY_STR":
-                filedef["content"] = self.proxy
+                filedef["content"] = self.proxy.dumpAllToString()["Value"]
             elif filedef["content"] == "EXECUTABLE_STR":
                 filedef["content"] = exe_str
             elif "STAMP_STR" in filedef["content"]:
@@ -398,11 +398,7 @@ def _renewCloudProxy(self):
         if not res["OK"]:
             self.log.error("Could not download proxy", res["Message"])
             return False
-        resdump = res["Value"].dumpAllToString()
-        if not resdump["OK"]:
-            self.log.error("Failed to dump proxy to string", resdump["Message"])
-            return False
-        self.proxy = resdump["Value"]
+        self.proxy = res["Value"]
         self.valid = datetime.datetime.utcnow() + proxyLifetime * datetime.timedelta(seconds=1)
         return True
 

diff --git a/src/DIRAC/Resources/Computing/ComputingElement.py b/src/DIRAC/Resources/Computing/ComputingElement.py
@@ -263,6 +263,7 @@ def available(self):
         self.log.verbose("Max Number of Jobs:", maxTotalJobs)
         self.log.verbose("Max Waiting Jobs:", maxWaitingJobs)
 
+        result["CEInfoDict"] = ceInfoDict
         # If we reached the maximum number of total jobs, then the CE is not available
         totalJobs = runningJobs + waitingJobs
         if totalJobs >= maxTotalJobs:
@@ -283,8 +284,6 @@ def available(self):
         if availableProcessors is not None:
             additionalJobs = min(additionalJobs, availableProcessors)
         result["Value"] = additionalJobs
-
-        result["CEInfoDict"] = ceInfoDict
         return result
 
     #############################################################################