fix test

alchemy-fr · Sep 25, 2023 · 2da6262 · 2da6262
1 parent 0263c91
commit 2da6262
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/cache/.gitkeep b/cache/.gitkeep
diff --git a/lib/Alchemy/Phrasea/Controller/Prod/ToolsController.php b/lib/Alchemy/Phrasea/Controller/Prod/ToolsController.php
@@ -316,14 +316,19 @@ public function changeThumbnailAction(Request $request)
 
             $media = $this->app->getMediaFromUri($tempoFile);
 
-            $this->getSubDefinitionSubstituer()->substituteSubdef($record, $request->get('subdef'), $media);
+            // no BC break before PHRAS-3918 when only "thumbnail" was substituable
+            if(($subdef = $request->get('subdef')) === null) {
+                $subdef = 'thumbnail';
+            }
+
+            $this->getSubDefinitionSubstituer()->substituteSubdef($record, $subdef, $media);
             $this->getDataboxLogger($record->getDatabox())
-                ->log($record, \Session_Logger::EVENT_SUBSTITUTE, $request->get('subdef'), '');
+                ->log($record, \Session_Logger::EVENT_SUBSTITUTE, $subdef, '');
 
             unlink($tempoFile);
             rmdir($tempoDir);
             $success = true;
-            $message = sprintf($this->app->trans('Subdef "%s" has been successfully substitued'), $request->get('subdef'));
+            $message = sprintf($this->app->trans('Subdef "%s" has been successfully substitued'), $subdef);
         }
         catch (\Exception $e) {
             $success = false;

diff --git a/tests/Alchemy/Tests/Phrasea/Controller/Prod/ToolsTest.php b/tests/Alchemy/Tests/Phrasea/Controller/Prod/ToolsTest.php
@@ -66,6 +66,6 @@ public function testRouteChangeThumb()
         $response = self::$DI['client']->getResponse();
         $message = trim($crawler->filterXPath('//div')->text());
         $this->assertEquals(200, $response->getStatusCode());
-        $this->assertEquals(self::$DI['app']['translator']->trans('Thumbnail has been successfully substitued'), $message);
+        $this->assertEquals(sprintf(self::$DI['app']['translator']->trans('Subdef "%s" has been successfully substitued'), 'thumbnail'), $message);
     }
 }