Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode_projects:1.0] Release plugin #198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sharsie
Copy link

@Sharsie Sharsie commented Mar 5, 2024

I have done a rewrite of my previous implementation into the new API, I know it is a more complex plugin than the other options, but my long standing goal is to support the Project Manager extension without relying too much on the recently opened files.

Additionally this implementation provides optional configuration to open VS Code through terminal for advanced use, e.g. where users need to load an environment prior to opening VS Code for example.
My usecase is direnv + nix shell, I have separate environments in each of my projects and entering those directories in shell loads all necessary dependencies and binaries needed for that specific project. This also requires VS Code to be opened from that directory in order to have the correct environment inside the IDE.

So here it is, if you find it useful, I'm happy to support it going forward, if not, I'll just support myself :)

@ManuelSchneid3r
Copy link
Member

Hi, quite a bunch of lines but i guess people will love it. Just a note: py api v2.3 is out. theres a matcher which does imlicit normalization and such.

@Sharsie
Copy link
Author

Sharsie commented Jun 29, 2024

I updated the plugin to use the latest version and the matcher, but noticed the iconUrls defined on the plugin itself stopped working with 0.24.1 (this is not just this plugin, but all of them). Icons on the item results work fine.

Are there any notes on how to migrate these? I noticed in the c++ version of the Timer plugin, that this is provided through a .qrc file

@ManuelSchneid3r
Copy link
Member

Are there any notes on how to migrate these? I noticed in the c++ version of the Timer plugin, that this is provided through a .qrc file

thats the c++ way to ship a plugin as a single module. icon urls should actually work as expected. they work on my system. but yes I changed the icon provider api and maybe introduced a bug. i have to check it on a linux box.

@ManuelSchneid3r ManuelSchneid3r requested a review from a team July 4, 2024 08:11
Provide a search of VSCode recent files and its
Project Manager extension

[vscode_projects:1.1] Upgrade the interface version to 2.2

Better explain the plugin settings

[vscode_projects:1.2] Always add action to open workdir through VSCode

If terminal command is specified, it becomes the default action while allowing
the user to still open the workdir using default VSCode action without running
through terminal

[vscode_projects:1.3] Use new Matcher introduced in interface version 2.3

[vscode_projects:1.3] Remove unnecessary slashes in the icons url

[vscode_projects:1.3] Use cached iconUrls when building the standard item result
Resolve symlinks to make sure only unique results are returned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants